Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 0.6.0; Reverted default values for metric types, let's not break compatibility there #101

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

bwplotka
Copy link
Member

No description provided.

Copy link
Contributor

@jmichalek132 jmichalek132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit since you don't want to break combability with this release do we also want to revert the change from this pr #99?

LGTM otherwise.

@bwplotka
Copy link
Member Author

Small nit since you don't want to break combability with this release do we also want to revert the change from this pr #99?

With any release we ideally don't break compatibility, but we want and can break compatibility (we are 0.x version) if necessary. I believe metric-interval is worth it, but I reverted metric types as it's more surprising and unwanted potentially. WDYT? @jmichalek132

Signed-off-by: bwplotka <[email protected]>
@jmichalek132
Copy link
Contributor

Small nit since you don't want to break combability with this release do we also want to revert the change from this pr #99?

With any release we ideally don't break compatibility, but we want and can break compatibility (we are 0.x version) if necessary. I believe metric-interval is worth it, but I reverted metric types as it's more surprising and unwanted potentially. WDYT? @jmichalek132

Yeah I think this is closer to behavior people would want, and it's not as breaking as changing the name of the flag. Okay with me.

@bwplotka bwplotka merged commit f711a84 into main Oct 14, 2024
7 checks passed
@bwplotka bwplotka deleted the cut0.6.0 branch October 14, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants