Add ability to send remote write 2.0 requests #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <[email protected]>
bwplotka
reviewed
Jan 21, 2025
metrics/write.go
Outdated
Comment on lines
271
to
276
| switch ts := any(tss).(type) { | ||
| case []*writev2.TimeSeries: | ||
| req = any(&writev2.Request{ | ||
| Timeseries: ts[i:end], | ||
| Symbols: st.Symbols(), | ||
| }).(R) |
There was a problem hiding this comment.
Yeah was experimenting. Generics work, but result in super tricky code. I'll revert back to what I had initially
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
bwplotka
reviewed
Feb 3, 2025
| timeout: time.Minute, | ||
| config: cfg, | ||
| gatherer: gatherer, | ||
| client: httpClient, |
bwplotka
reviewed
Feb 3, 2025
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| client := Client{ |
There was a problem hiding this comment.
Should we create this once in avalanche?
bwplotka
reviewed
Feb 3, 2025
| merr.Add(err) | ||
| c.logger.Error("error writing metrics", "error", err) |
There was a problem hiding this comment.
Should we log this downstream (when we handle merr?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on client_golang remote write 2.0 PR