Add concurrency limit for remote write #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
force-pushed
the
limit-concurrency
branch
from
c8cc20b
to
ca0b35e
Compare
|
Nice! Any plans to rebase, code changed slightly? |
arajkumar
force-pushed
the
limit-concurrency
branch
from
ca0b35e
to
836cc26
Compare
Prior to this commit, unbounded number of write would have been trigged from avalanche based on number of samples and batch size. Adding a new flag to limit the concurrency will be useful to simulate prometheus remote write sharding. Signed-off-by: Arunprasad Rajkumar <[email protected]>
arajkumar
force-pushed
the
limit-concurrency
branch
from
836cc26
to
9d83c3d
Compare
|
@bwplotka Done. PTAL. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, unbounded number of write would have been trigged from avalanche based on number of samples and batch size. Adding a new flag to limit the concurrency will be useful to simulate prometheus remote write sharding.
Signed-off-by: Arunprasad Rajkumar [email protected]