feat: Made sure summaries actually give output quantile objectives as well; improved flag docs and tests for complex type series calculation. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
changed the title
… well; improved flag docs and tests for complex type series calculation. Signed-off-by: bwplotka <[email protected]>
ridwanmsharif
approved these changes
Oct 1, 2024
| // Mimic some quantile objectives. | ||
| objectives := map[float64]float64{} | ||
| if c.cfg.SummaryObjectives > 0 { | ||
| parts := 100 / c.cfg.SummaryObjectives |
There was a problem hiding this comment.
qq: is it valid for summary objectives to be greater than 100?
There was a problem hiding this comment.
No, they should be from 0.0 to 1.0 - you can see I am dividing by 100.0 later on. Using 100 to have cheap integer mitigation of float precision issues when substracting things later on (:
saswatamcode
reviewed
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @saswatamcode @jmichalek132