Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mtypes CLI for generating realistic avalanche metric type distributions. #97

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Oct 8, 2024

Initially added (and carefully reviewed by @ridwanmsharif) in bwplotka/prombenchy#12, but it might belong here much more.

See mtypes Readme in the diff to learn why it's useful.

cc @jmichalek132 @ridwanmsharif

@bwplotka bwplotka requested a review from cstyan October 8, 2024 08:30
@bwplotka bwplotka force-pushed the mtypes branch 3 times, most recently from 17c6214 to 40b524d Compare October 8, 2024 08:38
…ibutions.

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
Copy link
Contributor

@jmichalek132 jmichalek132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bwplotka bwplotka merged commit 421ddd8 into main Oct 9, 2024
7 checks passed
@bwplotka bwplotka deleted the mtypes branch October 9, 2024 09:14
bwplotka added a commit that referenced this pull request Oct 9, 2024
See related discussion: #97 (comment)

> I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often?


cc @jmichalek132 

Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka added a commit that referenced this pull request Oct 9, 2024
See related discussion: #97 (comment)

> I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often?


cc @jmichalek132

Signed-off-by: Bartlomiej Plotka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants