[prometheus-elasticsearch-exporter] Update pod labels #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Bourque <[email protected]>
Signed-off-by: Jimmy Bourque <[email protected]>
|
PR ready for review please @svenmueller @desaintmartin @zeritti Please let me know if there are any questions. Thanks!!! |
zeritti
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Thank you, @jimmybchopps, for your PR. Please, see my comments below.
Adding the version label will cause an unnecessary restart of the exporter at release upgrade, even though the upgrade does not affect the pod template's spec.
Bumping version Co-authored-by: zeritti <[email protected]> Signed-off-by: jimmybchopps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
To increase traceability throughout the application by adding more of the standardized kubernetes labels to pod workloads in addition to the stateful set itself.
Special notes for your reviewer
Originally, the pod labels were only get the selector labels, this update adds all including the selector labels so no labels are being removed; only a few are being added to the pod.
Checklist
[prometheus-couchdb-exporter])