[prometheus-blackbox-exporter] adjust extraEnv handling #5722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakob3xD
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
Signed-off-by: Jakob Hahn <[email protected]>
monotek
requested changes
Jun 3, 2025
Signed-off-by: Jakob Hahn <[email protected]>
monotek
requested changes
Jun 3, 2025
Co-authored-by: André Bauer <[email protected]> Signed-off-by: Jakob <[email protected]>
monotek
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Change the
extraEnvhandling to cover all use cases.The current
exntraEnvandextraEnvFromSecretare limited in their use, asextraEnvalways usesvalueand it is therefore not possible to usevalueFromto reference fields from the pod.The
extraEnvFromSecretis limited to Secrets but configMaps are also a valid source, so replacing it with a genericextraEnvFromwhere both can be referenced.As this is a braking change, the chart version gets a major bump and an entry to the README gets added.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])