Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add system metadata labels #416

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cczhuang420
Copy link

@cczhuang420 cczhuang420 commented Mar 2, 2025

This PR is to export the system metadata labels along with metric and resource labels.

@cczhuang420 cczhuang420 force-pushed the system-metadat-labels branch from 2d12d2c to 03d92bf Compare March 2, 2025 23:55
@cczhuang420 cczhuang420 force-pushed the system-metadat-labels branch from 03d92bf to f92d214 Compare March 2, 2025 23:56
@cczhuang420 cczhuang420 marked this pull request as draft March 3, 2025 05:02
@SuperQ
Copy link
Contributor

SuperQ commented Mar 3, 2025

Sorry, this is a job or service discovery.

System metadata labels are defined by Prometheus, not by exporters.

@SuperQ SuperQ closed this Mar 3, 2025
@SuperQ SuperQ reopened this Mar 3, 2025
@SuperQ
Copy link
Contributor

SuperQ commented Mar 3, 2025

Sorry, I misunderstood this change. I think this needs more documentation and description as to why it is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants