Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore exited units when measuring CPU usage #97

Closed

Conversation

haavard
Copy link

@haavard haavard commented Aug 29, 2023

This avoids an unneccessary warning message for every oneshot and otherwise exited unit on the system for each scrape.

Improves on #38 and #44 by reducing the log volume

This avoids an unneccessary warning message for every oneshot and
otherwise exited unit on the system for each scrape.

Signed-off-by: Håvard Pettersson <[email protected]>
@pkern
Copy link

pkern commented Oct 8, 2023

I'd be really nice to have this fixed, as it's just a ton of log spam that needs persisting.

@jpds
Copy link
Contributor

jpds commented Oct 28, 2023

There's still one little source of noise:

systemd_exporter[48576]: ts=2023-10-28T17:26:17.349Z caller=systemd.go:371 level=warn unit=home.mount msg="couldn't get unit's metrics: %s" err="got 'no cgroup' from systemd for active unit (state=active substate=mounted subtype=zfs slice=-.slice)"

@SuperQ
Copy link
Contributor

SuperQ commented Oct 30, 2023

cgroup metrics have been removed.

See: #105

@SuperQ SuperQ closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants