Add guard to hot logging location in associator #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepalbi
force-pushed
the
pablo/guard-debug-logging-code-paths
branch
from
872cb10 to
6e98760
Compare
Signed-off-by: Pablo Balbi <[email protected]>
Signed-off-by: Pablo Balbi <[email protected]>
Signed-off-by: Pablo Balbi <[email protected]>
thepalbi
force-pushed
the
pablo/guard-debug-logging-code-paths
branch
from
6e98760 to
f9f0b88
Compare
cristiangreco
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a guard over some "hot" locations in the associator where debug logging is used. A recent commit in yace removed some if-guard that were in place to protect debug logging locations. The main problem with this is not the logging call itself, but the evaluation of the arguments (for example
regexpMapping.toString()), which was not executed when the guards where in place.When running yace at scale in our dev clusters (and even worse in our prod clusters) we noticed 20% of cpu time in profiles was consumed by the evaluation of
fmt.Sprintffrom the logging arguments, which wasn't before.