Allow Exemplars on all time series #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Stäber <[email protected]>
jonatan-ivanov
approved these changes
Mar 25, 2024
kakkoyun
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the Prometheus dev summit on 2022-11-10 there was consensus that
Previously exemplars were only allowed for counters and histogram buckets.
The change has been implemented in the Prometheus server and was merged on Mar 5, 2023 with prometheus/prometheus#11984.
This PR updates the OpenMetrics spec to explicity allow exemplars on all time series.
This is not a breaking change for client libraries producing OpenMetrics text format. Exemplars are optional, and time series without exemplars are of course still valid.
It might however break scrapers parsing OpenMetrics if these scrapers verify that exemplars can only be present for counters and histogram buckets.
Because of the potential breaking change, we create a new version 1.1.0 with this PR.