alertmanager: Replace typed fields with plain string values #4083
+122
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4029
The Jira API requests different fields value types depends on the custom field type itself.
Ref. https://developer.atlassian.com/server/jira/platform/jira-rest-api-examples/#setting-custom-field-data-for-other-field-types, for example:
While jiralert allowed field values with different types as well, it might be problematic in context of the Alertmanager.
github.com/trivago/tgo
was necessary to cast all keys to strings. Ref. jira integration #3590 (comment)anyOf
. From Kubernetes point of view, all field values must be declared as string and an additional transformation logic is necessary to convert string values to complex values.I feel that re-implement the logic from jiralert was design flaw while implement the jira notifier at Alertmanager.
WDYT: @simonpasquier @dswarbrick