Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation typo #1282

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix documentation typo #1282

merged 2 commits into from
Feb 24, 2025

Conversation

bzier
Copy link
Contributor

@bzier bzier commented Feb 20, 2025

PromethesuRegistry -> PrometheusRegistry

@bzier
Copy link
Contributor Author

bzier commented Feb 20, 2025

I expect this is a simple thing to get merged, but please let me know if you need anything from me. I see a message that "merge is not an allowed merge method in this repository". If I need to reopen the PR with different options, I'm happy to do so.

cc: @fstab @dhoard @tomwilkie @zeitlinger

@zeitlinger zeitlinger enabled auto-merge (squash) February 21, 2025 09:32
@zeitlinger
Copy link
Member

I expect this is a simple thing to get merged, but please let me know if you need anything from me. I see a message that "merge is not an allowed merge method in this repository".

not sure why you see this - just accept the licence button, then it should be merged.

Signed-off-by: Brian Zier <[email protected]>
auto-merge was automatically disabled February 21, 2025 16:45

Head branch was pushed to by a user without write access

@bzier
Copy link
Contributor Author

bzier commented Feb 21, 2025

@zeitlinger Thanks, I've addressed the DCO issue now. The guide suggested a rebase to do the sign-off. The push reset your auto-merge 🤷 I also updated the branch with the latest commits from over night, so it is current as I write this.

Here is what I see at the moment:
image

Let me know if there's anything else I should do. Thanks.

@zeitlinger zeitlinger merged commit ec99546 into prometheus:main Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants