feat: add retain() to Family to allow metrics filtering
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxinden what do you think of this approach? |
howardjohn
force-pushed
the
metrics/expiry
branch
from
9ec1f88 to
fb27004
Compare
howardjohn
force-pushed
the
metrics/expiry
branch
from
fb27004 to
cb64ace
Compare
howardjohn
force-pushed
the
metrics/expiry
branch
from
09896cf to
72bc78d
Compare
howardjohn
changed the title
howardjohn
changed the title
retain() to Family to allow metrics filtering
Signed-off-by: John Howard <[email protected]>
howardjohn
force-pushed
the
metrics/expiry
branch
from
72bc78d to
a6babae
Compare
|
Ok I have fixed this up and added documentation. Should be good to go from my perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #197.
This enables a way to filter metrics by arbitrary logic. The existing
remove()function is not suitable for this, as it requires us to know the entire label set we want to remove. Theclear()function is not as it clears everything.A simple doc test is added, as well as a more complex example that uses a custom counter to track the last-access-time and calls
retainbased on that.