Add CRL support to Prometheus #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2023 19:32
This commit adds support for certificate revocation status by Certificate
Revocation List (CRL) in Prometheus.
New fields 'CRL' and 'CRLFile' have been added to the Prometheus config
('tls_config' section). These enable certificate revocation validation
with the provided CRL.
The Prometheus loads the Certificate Revocation List (CRL) to validate the
revocation status of the peer's certificate chain by invoking the
'verifyPeerCertificate' (https://pkg.go.dev/crypto/tls) function during
a TLS handshake.
Signed-off-by: Ziqi Zhang <[email protected]>
Move and separate version-sensitive functionalities related to CRL into two go files within the config package so that it can build with the corresponding go version. Signed-off-by: Ziqi Zhang <[email protected]>
|
@roidelapluie Hi, Julien. |
|
I think that CRL is questionable: the fact we have to implement it ourselve is prone to add security bugs, additionally, there are concerns about CRL in general by the crypto/tls author itsels: https://www.imperialviolet.org/2014/04/19/revchecking.html What about we implement this when the go team decides to implement it in crypto/tls ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for certificate revocation status by Certificate Revocation List (CRL) in Prometheus.
New fields 'CRL' and 'CRLFile' have been added to the Prometheus config ('tls_config' section). These enable certificate revocation validation with the provided CRL.
The Prometheus loads the Certificate Revocation List (CRL) to validate the revocation status of the peer's certificate chain by invoking the 'verifyPeerCertificate' (https://pkg.go.dev/crypto/tls) function during a TLS handshake.
@roidelapluie Hi, Julien. Please take a look. Thank you.