Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect operator autopilot health metrics #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chuckyz
Copy link

@chuckyz chuckyz commented Nov 10, 2020

This extends the exporter to collect everything exposed by the https://www.consul.io/api-docs/operator/autopilot#read-health endpoint. Naming is weird, but I wanted to call out that this isn't something that should typically be collected unless you need to keep track of really low level stats.

This is my first time extending a prometheus exporter and I find this one super helpful, thank you all for all your hard work and please let me know if anything here is super wrong. :)

@chuckyz chuckyz force-pushed the operator_autopilot_health branch from f16696b to d8adc02 Compare November 10, 2020 08:16
@chuckyz
Copy link
Author

chuckyz commented Nov 10, 2020

Ignore previous iterations of this comment I was building off my local master... 🤦

Fixing test issues and lint problems now.

@chuckyz chuckyz force-pushed the operator_autopilot_health branch from 75072ae to 4a57f65 Compare November 10, 2020 18:27
@SuperQ SuperQ self-requested a review November 10, 2020 20:13
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. A few questions/remarks but nothing blocking.

consul_exporter.go Outdated Show resolved Hide resolved
consul_exporter.go Outdated Show resolved Hide resolved
@chuckyz chuckyz force-pushed the operator_autopilot_health branch 2 times, most recently from fb2569a to bda7d1d Compare November 20, 2020 04:32
@chuckyz
Copy link
Author

chuckyz commented Nov 20, 2020

I had to soft rebase off origin's head, and then git commit --signoff followed by git push +operator_autopilot_health.

For anyone who journeys here and hits something similar, hopefully https://gist.github.com/patik/b8a9dc5cd356f9f6f980#the-harder-and-less-flexible-way helps to clean up.

Also, for DCO bot whatever reason commits from my Windows desktop with my main email never pass the DCO check.

@chuckyz chuckyz force-pushed the operator_autopilot_health branch from bda7d1d to 96246aa Compare November 23, 2020 20:00
@stale stale bot added the stale label Jan 23, 2021
@simonpasquier
Copy link
Member

Apologies for the very belated answer. Would you be able to rebase?

@stale stale bot removed the stale label Jan 29, 2021
@chuckyz
Copy link
Author

chuckyz commented Feb 8, 2021

@simonpasquier I can.

In Consul 1.9 they also added a lot of new autopilot metrics that are extremely useful. Do you have a way to deal with version breakage?

@stale stale bot added the stale label Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants