Removed remote-write-receiver allowed values in enable-feature flag #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav <[email protected]>
bwplotka
requested changes
Jul 5, 2024
There was a problem hiding this comment.
Yes, but this is a blog post from 2021 and we cannot possibly maintain all old flags ever used in old blog posts (: In fact it might be surprising -- you expect 2021 version of Prometheus to have this feature flag etc.
Thus, I would NOT do this, but thank you for your contribution anyway! What do you think?
Tusenka
approved these changes
Oct 6, 2024
|
Agreed, we also don't update old blog posts with all of the new flags as well. I don't think we should change this. |
Tusenka
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--enable-feature=remote-write-receiverflag is deprecated and is going to be removed from Prometheus 3.0 and instead users should use--web.enable-remote-write-receiver.Refs - prometheus/prometheus#13206 prometheus/prometheus#13435