Basic auth: add metrics

[roidelapluie]

Signed-off-by: Julien Pivotto [email protected]

[roidelapluie]

Ready for a second review, once that is in I will add metrics for the TLS part (or I can do in the same PR if you want)

[brian-brazil]

https and basic auth are not the same thing

In general, it's better to have the metric name as a single string literal as it makes grepping and determining what the actual metric name is easier.

[roidelapluie]

I have renamed the metric. However I think that keeping namespace separated is better, it that's fine for you.

[SuperQ]

I preferred it named based on the package name.

[roidelapluie]

Should we change the package name?

[roidelapluie]

Would renaming the package to http help, like this?

[roidelapluie]

I did not like the "http" package rename as it is too close with go's net/http.

I have reworked this to have a metric name: prometheus_toolkit_https_basic_authentication_failures_total which does not read as 'https_requests' anymore. does it sound better ?