Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Go standard errors #242

Merged
merged 1 commit into from
Mar 3, 2024
Merged

use Go standard errors #242

merged 1 commit into from
Mar 3, 2024

Conversation

mmorel-35
Copy link
Contributor

  • Since Dec 1, 2021, github.com/pkg/errors is an archived project.
  • Since go 1.13, there is a standard errors and fmt modules that provides equivalent ways to handle errors.

Signed-off-by: Matthieu MOREL [email protected]

@matthiasr
Copy link
Contributor

Thank you! Could you please rebase on top of main to get the latest changes?

@mmorel-35 mmorel-35 force-pushed the errors branch 3 times, most recently from 14755e2 to 8bab0c5 Compare December 6, 2023 18:31
@mmorel-35
Copy link
Contributor Author

Hi @matthiasr ,
This shall be good to go now ;)!

@mmorel-35 mmorel-35 marked this pull request as draft January 15, 2024 22:33
@mmorel-35 @matthiasr
use Go standard errors
e4b07b5 
Signed-off-by: Matthieu MOREL <[email protected]>
@matthiasr matthiasr marked this pull request as ready for review March 3, 2024 11:31
@matthiasr matthiasr merged commit 9c37bef into prometheus:master Mar 3, 2024
3 of 4 checks passed
@matthiasr
Copy link
Contributor

Thank you! Sorry for being a bit absent – to avoid another round-trip fail, I rebased this myself now 😅

@mmorel-35 mmorel-35 deleted the errors branch March 3, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @matthiasr