Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: adopt log/slog, drop go-kit/log #277

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

tjhop
Copy link
Contributor

@tjhop tjhop commented Oct 29, 2024

The bulk of this change set was automated by the following script which is being used to aid in converting the various exporters/projects to use slog:

https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434

Other changes include:

  • updates the statsd_exporter codebase to v0.28.0 to use statsd_exporter MetricMapper code that uses log/slog.
  • update prometheus codebase to commit prometheus/prometheus@911c3ef, which corresponds to the 3.0 beta 1 release. This is required to use new prometheus code that uses log/slog.
  • refactors/fixes around the tsdb handling in the backfill command for current function signatures/usage.
  • updates deprecated golangci-lint configs
  • enables sloglint linter

The bulk of this change set was automated by the following script which
is being used to aid in converting the various exporters/projects to use
slog:

https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434

Other changes include:

- updates the statsd_exporter codebase to v0.28.0 to use statsd_exporter
  MetricMapper code that uses log/slog.
- update prometheus codebase to commit
  prometheus/prometheus@911c3ef,
which corresponds to the 3.0 beta 1 release. This is required to use new
prometheus code that uses log/slog.
- refactors/fixes around the tsdb handling in the backfill command for
  current function signatures/usage.
- updates deprecated golangci-lint configs
- enables sloglint linter

Signed-off-by: TJ Hoplock <[email protected]>
@tjhop
Copy link
Contributor Author

tjhop commented Oct 29, 2024

cc: @SuperQ @matthiasr

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@SuperQ SuperQ merged commit 22beb8a into prometheus:master Oct 29, 2024
4 checks passed
SuperQ added a commit that referenced this pull request Oct 29, 2024
* [CHANGE] Replace logging with Go slog library #277

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants