-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples of Apache Ignite 2.6.0 basic JMX metrics #319
base: main
Are you sure you want to change the base?
Conversation
7ed010f
to
7a1cf49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have example output?
example_configs/ignite_2.6.0.yml
Outdated
@@ -0,0 +1,95 @@ | |||
# Licensed to the Apache Software Foundation (ASF) under one or more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't put this in these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
lowercaseOutputLabelNames: true | ||
lowercaseOutputName: true | ||
rules: | ||
# Apache Ignite provide runtime information on a cluster. Keep in mind that there will be a certain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be better to get the data from the individual processes directly, rather than adding jitter and lag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brian, Could you, please, calrify? In general, I agree that it's better to share individual processes metrics. But I would like to have an batch of heap and non-heap metrics for the whole cluster.
name: ignite_cluster_heap_$1 | ||
help: Ignite cluster amount of heap memory in bytes | ||
labels: | ||
attr: $3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metric names should be in the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't done, all these attrs should be in the metric name.
example_configs/ignite_2.6.0.yml
Outdated
# | ||
# see https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cluster/ClusterMetrics.html | ||
- pattern: "^org.apache<clsLdr=(.+), group=Kernal, name=ClusterMetrics(.+)><>(HeapMemory.*):" | ||
name: ignite_cluster_heap_$1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clsLdr sounds like a label - does it vary as the leader changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brian, it remains the same for single cluster but can be changed if e.g. we will run another. What should I do with this? Is it valid name metric name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should drop it.
# see https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cluster/ClusterMetrics.html | ||
- pattern: "^org.apache<clsLdr=(.+), group=Kernal, name=ClusterMetrics(.+)><>(HeapMemory.*):" | ||
name: ignite_cluster_heap_$1 | ||
help: Ignite cluster amount of heap memory in bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you know it's in bytes, append _bytes to the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Added. JVM metrics used as an example.
help: Ignite durable memory pages currently loaded in RAM | ||
labels: | ||
attr: $3 | ||
- pattern: "^org.apache<clsLdr=(.+), group=DataRegionMetrics, name=(.+)><>(Off[Hh]eap.*|MaxSize|PhysicalMemorySize|TotalAllocatedSize):" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the usual JVM memory metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brian, no these metrics are collected through the whole cluster on specific memory region
. They are not bounded to JVMs.
example_configs/ignite_2.6.0.yml
Outdated
help: Ignite cluster job detalization | ||
labels: | ||
attr: $3 | ||
type: COUNTER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Counters should end in _total
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
e11f5c2
to
98f203b
Compare
Example,
|
c2b0681
to
f74d309
Compare
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
Signed-off-by: Maxim Muzafarov <[email protected]>
a5cf8b2
to
6cc565e
Compare
@brian-brazil |
clsLdr is still in there, did you forget to push? |
@brian-brazil yes, I'll update PR shortly. |
any news? |
@brian-brazil , @skonto
Hi Brian, Stavros
Can you review my changes?
I've added basic JMX metrics for Apache Ignite https://ignite.apache.org/ project for version 2.6.0. Hope they will help somebody to use this tool.
Kind regards,
Maxim Muzafarov