Align kafka connect metrics #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexivsn <[email protected]>
superfav
approved these changes
Feb 10, 2022
Comment on lines
+65
to
+71
| - pattern: 'kafka.(.+)<type=connector-metrics, connector=(.+)><>(connector-class|connector-type|connector-version|status): (.+)' | ||
| name: kafka_connect_connector_$3 | ||
| value: 1 | ||
| labels: | ||
| connector: "$2" | ||
| $3: "$4" | ||
| help: "Kafka Connect $3 JMX metric type connector" |
There was a problem hiding this comment.
The first group is unused. Can it be removed?
Suggested change
| - pattern: 'kafka.(.+)<type=connector-metrics, connector=(.+)><>(connector-class|connector-type|connector-version|status): (.+)' | |
| name: kafka_connect_connector_$3 | |
| value: 1 | |
| labels: | |
| connector: "$2" | |
| $3: "$4" | |
| help: "Kafka Connect $3 JMX metric type connector" | |
| - pattern: 'kafka.connect<type=connector-metrics, connector=(.+)><>(connector-class|connector-type|connector-version|status): (.+)' | |
| name: kafka_connect_connector_$2 | |
| value: 1 | |
| labels: | |
| connector: "$1" | |
| $2: "$3" | |
| help: "Kafka Connect $2 JMX metric type connector" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Kafka connect task status is exposed under kafka_connect_connector_status which is not the connector status, and if the connector failed to start nothing gets exposed, I have added the Kafka connect connector metrics and renamed the existing status to kafka_connect_connector_task_status, more details are provided here:
#633
Signed-off-by: alexivsn [email protected]