Added option to scrape all types of attributes #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Umut Sahin <[email protected]>
Signed-off-by: Umut Sahin <[email protected]>
Signed-off-by: Umut Sahin <[email protected]>
|
Hi @dhoard, is there anything missing from my side to get this PR merged ? |
|
@umutsahin I don't see any JUnit tests for the changes. (I'm working on a robust integration test suite.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fstab, @tomwilkie
The reason I have created this PR is while scraping JMX metrics from apache ignite, if I used JMXMetricsSpi, exporter was not able to parse any of the metrics provided by specific SPI. The Attributes are returned as POJOs instead of the expectation Attribute implementation.
I have added an option to scrape everything from JMX, current implementation scrapes Attribute instances only.
Config key:
scrapeAllAttributesSigned-off-by: Umut Sahin [email protected]