Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export direct_reclaims_total metric to prometheus #227

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Export direct_reclaims_total metric to prometheus #227

wants to merge 4 commits into from

Conversation

Vandit1604
Copy link

fixes #136

@Vandit1604
add direct_reclaim metric
b6ed409 
Signed-off-by: Vandit Singh <[email protected]>
SuperQ
SuperQ requested changes Sep 1, 2024
View reviewed changes
pkg/exporter/exporter.go Outdated Show resolved Hide resolved
@Vandit1604 @SuperQ
Update pkg/exporter/exporter.go
5b10c07 
Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Vandit Singh <[email protected]>
@Vandit1604 Vandit1604 changed the title Export total_direct_reclaim metric to prometheus Export direct_reclaims_total metric to prometheus Sep 2, 2024
@Vandit1604
Copy link
Author

@SuperQ Is there anything else that needs to be done here to complete the PR?

SuperQ
SuperQ reviewed Oct 17, 2024
View reviewed changes
README.md Outdated
Comment on lines 48 to 49
# HELP memcached_total_direct_reclaims Times worker threads had to directly reclaim or evict items.
# TYPE memcached_total_direct_reclaims counter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be updated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ requested changes

@Sticksman Sticksman Sticksman approved these changes

@matthiasr matthiasr matthiasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export "direct_reclaims"
4 participants
@Vandit1604 @matthiasr @SuperQ @Sticksman