Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Native Histogram Text Format #32

Merged
merged 9 commits into from
Oct 22, 2024

Commits on Jan 29, 2024

  1. Proposal for Native Histogram Text Format

    Create an initial prosal for supporting native histograms in the text
    format. It mainly links to the design doc for ease of comments while we
    decide on a path forward. After a proposal from the design doc has some
    support the rest of the markdown proposal will be filled out.
    
    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d74f88a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Address review feedback

    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6ce4170 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Update proposal with the results of the design doc

    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b1283f1 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    f80fafa View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Address review feedback

    The significant changes are:
    1. Add additional examples.
    2. Add a proposal for how content negotiation will be done until OM 1.1
       is released.
    3. Plural form of arrays in the schema.
    4. Added support for multiple exemplars as a non-goal.
    
    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed May 30, 2024
    Configuration menu
    Copy the full SHA
    2920fb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Address review comments

    * Tightened up some language of how to tell classic and native
      histograms apart.
    * Added that whitespace is not allowed inside of a value.
    
    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    cec73ef View commit details
    Browse the repository at this point in the history
  2. Add example for combined histogram with labels

    Illustrate that ordering matters for this new format to aid parsing.
    
    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6ffbe74 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Include support for multiple exemplars

    Provide a paragraph describing support for multiple exemplars as part of
    this proposal. Currently it is left ambiguous if a list of exemplars can
    be included on more than native histograms, we can define that
    explicitly when writing the new OpenMetrics spec.
    
    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7af9827 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Add additional non-goals

    Explicitly state that changing created timestamp semantics and allowing
    custom buckets as part of the native histogram structure are not goals
    for this proposal.
    
    Signed-off-by: Chris Marchbanks <[email protected]>
    csmarchbanks committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3717133 View commit details
    Browse the repository at this point in the history