Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push an abridged README to Docker Hub #642

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Push an abridged README to Docker Hub #642

merged 1 commit into from
Jun 5, 2024

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented May 22, 2024

The full README.md exceeds the character limit for the description on Docker Hub. This commit pushes an abridged README-docker.md to Docker Hub. It contains a reference to the full README.md.

@beorn7 beorn7 requested a review from SuperQ May 22, 2024 13:15
@@ -13,7 +13,7 @@ permissions:
jobs:
PushDockerHubReadme:
runs-on: ubuntu-latest
name: Push README to Docker Hub
name: Push an abridged README to Docker Hub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is synced from prometheus/prometheus, changes will be overwritten.

@SuperQ
Copy link
Member

SuperQ commented May 22, 2024

Maybe we should move some of the text to other documentation files?

@beorn7
Copy link
Member Author

beorn7 commented May 22, 2024

So far, having all the documentation for a relatively simple app just in README.md served us well.
Maybe it's time to move on to "real" documentation, but I don't want this to be motivated by a character limit on Docker Hub in combination with the inflexibility of our tooling.

@beorn7
Copy link
Member Author

beorn7 commented May 22, 2024

Is there some way to implement an override for the GH actions? Should we create one?

@beorn7
Copy link
Member Author

beorn7 commented May 23, 2024

Here is an idea: readme_file: 'README.md' is the default behavior anyway, so we could just leave it out. This has the additional twist that the tool will prefer a file called README-containers.md if it exists. (At least that's how I understand https://github.com/christian-korneck/docker-pushrm .) This behavior seems to be precisely tailored to the use case at hand here.

So plan would be:

  1. Remove readme_file: 'README.md' from the source in prometheus/prometheus.
  2. Let it propagate.
  3. Rename README-docker.md in this PR to README-containers.md (and revert the other changes).

Only drawback is that it will deliver the shorter README also to Quay (which apparently allows larger descriptions), but I guess that's fine.

WDYT?

@beorn7
Copy link
Member Author

beorn7 commented Jun 4, 2024

@SuperQ what do you think about the idea above?

@beorn7
Copy link
Member Author

beorn7 commented Jun 4, 2024

Chatted with @SuperQ , and the plan seems to work.

prometheus/prometheus#14211 is merged for step 1. We have to wait until it has propagated (step 2), and then I will change this PR to implement step 3.

The full README.md exceeds the character limit for the description on
Docker Hub. This commit adds a shorter READE-containers.md, which is
then used as the container description (on both Docker Hub ond Quay,
for consistency). It contains a reference to the full README.md.

Signed-off-by: beorn7 <[email protected]>
@beorn7
Copy link
Member Author

beorn7 commented Jun 5, 2024

Updated according to the new plan. @SuperQ PHAL.

@beorn7 beorn7 merged commit 3220be2 into master Jun 5, 2024
4 checks passed
@beorn7 beorn7 deleted the beorn7/ci branch June 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants