Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch MIBs to import DisplayString from SNMPv2-TC instead of RFC1213-MIB #868

Merged
merged 1 commit into from
May 2, 2023
Merged

Patch MIBs to import DisplayString from SNMPv2-TC instead of RFC1213-MIB #868

merged 1 commit into from
May 2, 2023

Conversation

candlerb
Copy link
Contributor

Fixes #867

@candlerb
Copy link
Contributor Author

Looks like CI doesn't like my sed command - probably a different flavour of sed :-(

@SuperQ
Copy link
Member

SuperQ commented May 1, 2023

This patch is fine for now, I've filed #872 as a possible long-term solution.

SuperQ
SuperQ requested changes May 1, 2023
View reviewed changes
generator/Makefile Show resolved Hide resolved
SuperQ
SuperQ approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit b65f29c into prometheus:main May 2, 2023
@SuperQ SuperQ mentioned this pull request May 2, 2023
Closed
SuperQ added a commit that referenced this pull request Jun 15, 2023
@SuperQ
Release v0.22.0
8541efc 
* [FEATURE] Add indices filters #624
* [FEATURE] Add MIBOPTS flag to the generator #891
* [ENHANCEMENT] Treat Bits as OctetString #870
* [ENHANCEMENT] Report duration in logs for canceled scrapes #876
* [BUGFIX] Fix several generator MIBs. #843, #868, #889

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Jun 15, 2023
Merged
SuperQ added a commit that referenced this pull request Jun 15, 2023
@SuperQ
Release v0.22.0 (#896)
7b0657f 
* [FEATURE] Add indices filters #624
* [FEATURE] Add MIBOPTS flag to the generator #891
* [ENHANCEMENT] Treat Bits as OctetString #870
* [ENHANCEMENT] Report duration in logs for canceled scrapes #876
* [BUGFIX] Fix several generator MIBs. #843, #868, #889

Signed-off-by: SuperQ <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@candlerb
Patch MIBs to import DisplayString from SNMPv2-TC instead of RFC1213-…
367b490 
…MIB (prometheus#868)

Fixes prometheus#867

Signed-off-by: Brian Candler <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Release v0.22.0 (prometheus#896)
2f1332a 
* [FEATURE] Add indices filters prometheus#624
* [FEATURE] Add MIBOPTS flag to the generator prometheus#891
* [ENHANCEMENT] Treat Bits as OctetString prometheus#870
* [ENHANCEMENT] Report duration in logs for canceled scrapes prometheus#876
* [BUGFIX] Fix several generator MIBs. prometheus#843, prometheus#868, prometheus#889

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"make generate" reports msg="NetSNMP reported parse error(s)" errors=2
2 participants
@candlerb @SuperQ