Treat Bits as OctetString #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sébastien Coavoux <[email protected]>
sebastien-coavoux
force-pushed
the
fix-bits-lookup
branch
from
eb1a0e3
to
04f5c0a
Compare
|
poke @SuperQ in case you missed it |
SuperQ
added a commit
that referenced
this pull request
Jun 15, 2023
* [FEATURE] Add indices filters #624 * [FEATURE] Add MIBOPTS flag to the generator 891 * [ENHANCEMENT] Treat Bits as OctetString #870 * [ENHANCEMENT] Report duration in logs for canceled scrapes #876 Signed-off-by: SuperQ <[email protected]>
Merged
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
Signed-off-by: Sébastien Coavoux <[email protected]> Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
* [FEATURE] Add indices filters prometheus#624 * [FEATURE] Add MIBOPTS flag to the generator prometheus#891 * [ENHANCEMENT] Treat Bits as OctetString prometheus#870 * [ENHANCEMENT] Report duration in logs for canceled scrapes prometheus#876 * [BUGFIX] Fix several generator MIBs. prometheus#843, prometheus#868, prometheus#889 Signed-off-by: SuperQ <[email protected]> Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #855 , looks like this quick fix is the best option until we have a use case to elaborate more