Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exporter-toolkit #586

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Update exporter-toolkit #586

merged 1 commit into from
Oct 25, 2024

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Oct 10, 2024

  • Update Go to 1.23.
  • Replace go-kit/log with slog.

@SuperQ SuperQ force-pushed the superq/slog branch 3 times, most recently from 6c448a1 to f09a057 Compare October 10, 2024 09:27
@SuperQ SuperQ requested a review from matthiasr October 10, 2024 09:30
Copy link

@tjhop tjhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few suggestions to improve "naked" errors, but looks great 👍

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/listener/listener.go Outdated Show resolved Hide resolved
pkg/listener/listener.go Outdated Show resolved Hide resolved
* Update Go to 1.23.
* Replace go-kit/log with slog.

Signed-off-by: SuperQ <[email protected]>
@SuperQ
Copy link
Member Author

SuperQ commented Oct 11, 2024

Incorporated suggestions.

Copy link

@tjhop tjhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tjhop
Copy link

tjhop commented Oct 23, 2024

@matthiasr is there any chance you could take a look at this sometime? The graphite_exporter imports the statsd_exporter to use the mapper.MetricMapping struct, so it seems this is a prereq to updating the graphite_exporter to fully use log/slog

@matthiasr
Copy link
Contributor

Thank you both 🙏 🙏 🙏

@matthiasr matthiasr merged commit 8aac1ca into master Oct 25, 2024
5 checks passed
@matthiasr matthiasr deleted the superq/slog branch October 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants