Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS Certificate to prombench.prometheus.io #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions prombench/manifests/cert-manager/1b_certificate.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: prometheus-meta
namespace: default
spec:
dnsNames:
- prombench.prometheus.io
secretName: prombench-prometheus-tls
issuerRef:
name: letsencrypt-cluster-issuer
kind: ClusterIssuer
15 changes: 15 additions & 0 deletions prombench/manifests/cert-manager/1c_issuer.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
name: letsencrypt-cluster-issuer
spec:
acme:
server: https://acme-v02.api.letsencrypt.org/directory
email: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an email Prometheus specific?

Copy link
Contributor Author

@Vandit1604 Vandit1604 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whose email should I put here? I added mine when I was testing locally.

privateKeySecretRef:
name: letsencrypt-prod
solvers:
- http01:
ingress:
class: nginx

8 changes: 6 additions & 2 deletions prombench/manifests/cluster-infra/3b_prometheus-meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ metadata:
prometheus: meta
app: prometheus-meta
spec:
type: NodePort
type: ClusterIP
ports:
- name: prom-web
port: 80
Expand All @@ -257,9 +257,13 @@ kind: Ingress
metadata:
name: ingress-prometheus-meta
annotations:
nginx.ingress.kubernetes.io/ssl-redirect: "false"
nginx.ingress.kubernetes.io/ssl-redirect: "true"
spec:
ingressClassName: nginx
tls:
- hosts:
- prombench.prometheus.io
secretName: prombench-prometheus-tls
rules:
- http:
paths:
Expand Down