fix: Do not redeclare avatars (#2)

prompt · Dec 1, 2024 · 0175127 · 0175127
1 parent 2aba72f
commit 0175127
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/index.ts b/src/index.ts
@@ -3,15 +3,15 @@ export default {
 		const { pathname } = new URL(request.url);
 
 		if (!pathname || pathname === '/') {
-			return Response.redirect('https://github.com/prompt/avatars.dog', 307);
+			return Response.redirect(env.README_REDIRECT, 307);
 		}
 
 		const [actor, format] = pathname.toLowerCase().slice(1).split('@');
 
 		let avatar = await env.avatars.get(actor);
 
 		if (!avatar) {
-			let avatar = await fetch(`${env.BLUESKY_GET_PROFILE}?actor=${actor}`, { method: 'GET' })
+			avatar = await fetch(`${env.BLUESKY_GET_PROFILE}?actor=${actor}`, { method: 'GET' })
 				.then<{ avatar: string }>((response) => response.json())
 				.then<string>((profile) => profile.avatar || '404');
 
@@ -20,7 +20,7 @@ export default {
 			});
 		}
 
-		if (!avatar || !avatar.startsWith('https://cdn.bsky.app/img/avatar')) {
+		if (!avatar || !avatar.startsWith(`${env.BLUESKY_CDN}/img/avatar`)) {
 			return new Response(`Avatar not found for ${actor}.`, { status: 404 });
 		}
 

diff --git a/worker-configuration.d.ts b/worker-configuration.d.ts
@@ -2,7 +2,8 @@
 
 interface Env {
 	avatars: KVNamespace;
-	BLUESKY_CDN: 'https://cdn.bsky.app';
-	BLUESKY_GET_PROFILE: 'https://public.api.bsky.app/xrpc/app.bsky.actor.getProfile';
+	BLUESKY_CDN: "https://cdn.bsky.app";
+	BLUESKY_GET_PROFILE: "https://public.api.bsky.app/xrpc/app.bsky.actor.getProfile";
 	CACHE_EXPIRY_TTL: 300;
+	README_REDIRECT: "https://github.com/prompt/avatars.dog";
 }
diff --git a/wrangler.toml b/wrangler.toml
@@ -15,3 +15,4 @@ id = "77bab70fe5cf495ea02dcc372bf6d124"
 BLUESKY_CDN = "https://cdn.bsky.app"
 BLUESKY_GET_PROFILE = "https://public.api.bsky.app/xrpc/app.bsky.actor.getProfile"
 CACHE_EXPIRY_TTL = 300
+README_REDIRECT = "https://github.com/prompt/avatars.dog"