Fix app-connector test

proofcarryingdata · Oct 27, 2024 · 32b3883 · 32b3883
1 parent 16729db
commit 32b3883
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/packages/app-connector/test/parcnet-connector.spec.ts b/packages/app-connector/test/parcnet-connector.spec.ts
@@ -35,10 +35,16 @@ describe("parcnet-client should work", function () {
     const client = new ParcnetRPCConnector(chan.port2, mockDialog);
     expect(client.isConnected()).to.be.false;
 
-    client.start(() => {
-      // This is called when the connection is established
-      expect(client.isConnected()).to.be.true;
-    });
+    client.start(
+      () => {
+        // This is called when the connection is established
+        expect(client.isConnected()).to.be.true;
+      },
+      () => {
+        // This is called if the connection fails. We should never get here.
+        assert(false);
+      }
+    );
 
     postRPCMessage(chan.port1, {
       type: RPCMessageType.PARCNET_CLIENT_READY

diff --git a/packages/app-connector/test/utils.ts b/packages/app-connector/test/utils.ts
@@ -1,5 +1,5 @@
 import { RPCMessageType } from "@parcnet-js/client-rpc";
-import { expect } from "vitest";
+import { assert, expect } from "vitest";
 import type { DialogController } from "../src/adapters/iframe.js";
 import { postRPCMessage } from "../src/adapters/iframe.js";
 import { ParcnetRPCConnector } from "../src/rpc_client.js";
@@ -19,10 +19,16 @@ export async function connectedClient(): Promise<{
 }> {
   const chan = new MessageChannel();
   const client = new ParcnetRPCConnector(chan.port2, mockDialog);
-  client.start(() => {
-    // This is called when the connection is established
-    expect(client.isConnected()).to.be.true;
-  });
+  client.start(
+    () => {
+      // This is called when the connection is established
+      expect(client.isConnected()).to.be.true;
+    },
+    () => {
+      // This is called if the connection fails. We should never get here.
+      assert(false);
+    }
+  );
 
   postRPCMessage(chan.port1, {
     type: RPCMessageType.PARCNET_CLIENT_READY