Addressing code reviews #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fix CORS issue when connecting to the local kv store for developing
|
@artwyman merging this now. Feel free to make comments any time, I'll address in future PRs. Thanks! |
artwyman
reviewed
Jul 24, 2024
| max: BigInt(getDates().eighteenYearsAgo.getTime()) | ||
| } | ||
| }, | ||
| // Prove the presence of an entry called "socialSecurityNumber", hide its value |
There was a problem hiding this comment.
The separation of ID number and SSN is realistic, though seems somewhat redundant for the level of detail of this example. Could probably just use idNumber for both sanctions list and correlation to paystub? I don't have a strong opinion on it, though.
Merged
|
Addressed the comments in this PR: #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing code reviews: #15.
There is still one issue not addressed. Tracked here:
#17