ticket previews loading properly

proofcarryingdata · Sep 27, 2024 · 5e3e65e · 5e3e65e
1 parent d67f76d
commit 5e3e65e
Show file tree

Hide file tree

Showing 9 changed files with 41 additions and 17 deletions.
diff --git a/apps/passport-server/src/routing/routes/genericIssuanceRoutes.ts b/apps/passport-server/src/routing/routes/genericIssuanceRoutes.ts
@@ -673,6 +673,7 @@ export function initGenericIssuanceRoutes(
     "/generic-issuance/api/ticket-previews/:email/:orderCode",
     async (req, res) => {
       checkGenericIssuanceServiceStarted(genericIssuanceService);
+
       const email = checkUrlParam(req, "email");
       const orderCode = checkUrlParam(req, "orderCode");
 

diff --git a/apps/passport-server/src/services/generic-issuance/GenericIssuanceService.ts b/apps/passport-server/src/services/generic-issuance/GenericIssuanceService.ts
@@ -56,13 +56,15 @@ import {
   IBadgeGiftingDB,
   IContactSharingDB
 } from "../../database/queries/ticketActionDBs";
+import { PCDHTTPError } from "../../routing/pcdHttpError";
 import { ApplicationContext } from "../../types";
 import { logger } from "../../util/logger";
 import { DiscordService } from "../discordService";
 import { EmailService } from "../emailService";
 import { PagerDutyService } from "../pagerDutyService";
 import { PersistentCacheService } from "../persistentCacheService";
 import { InMemoryPipelineAtomDB } from "./InMemoryPipelineAtomDB";
+import { PretixPipeline } from "./pipelines/PretixPipeline";
 import { Pipeline, PipelineUser } from "./pipelines/types";
 import { CredentialSubservice } from "./subservices/CredentialSubservice";
 import { PipelineSubservice } from "./subservices/PipelineSubservice";
@@ -351,16 +353,30 @@ export class GenericIssuanceService {
     email: string,
     orderCode: string
   ): Promise<TicketPreviewResultValue> {
+    const devconPipelineId = process.env.DEVCON_PIPELINE_ID;
+    const devconPipeline = (await this.getAllPipelineInstances()).find(
+      (p) => p.id === devconPipelineId && PretixPipeline.is(p)
+    ) as PretixPipeline | undefined;
+
+    if (!devconPipeline) {
+      throw new PCDHTTPError(
+        400,
+        "devcon pipeline not found " + devconPipelineId
+      );
+    }
+
+    const tickets = await devconPipeline.getAllTickets();
+
+    const matchingTickets = tickets.atoms.filter(
+      (atom) => atom.email === email && atom.orderCode === orderCode
+    );
+
+    const ticketDatas = matchingTickets.map((atom) =>
+      devconPipeline.atomToPODTicketData(atom, "1234")
+    );
+
     return {
-      tickets: [
-        {
-          name: "Test",
-          email: "[email protected]",
-          ticketSecret: "test",
-          eventName: "Test Event",
-          productName: "Test Product"
-        }
-      ]
+      tickets: ticketDatas
     } satisfies TicketPreviewResultValue;
   }
 }
diff --git a/apps/passport-server/src/services/generic-issuance/pipelines/PretixPipeline.ts b/apps/passport-server/src/services/generic-issuance/pipelines/PretixPipeline.ts
@@ -1119,7 +1119,7 @@ export class PretixPipeline implements BasePipeline {
     });
   }
 
-  private atomToPODTicketData(
+  public atomToPODTicketData(
     atom: PretixAtom,
     semaphoreV4Id: string
   ): IPODTicketData {

diff --git a/packages/lib/passport-interface/package.json b/packages/lib/passport-interface/package.json
@@ -66,6 +66,7 @@
     "@pcd/pcd-collection": "0.11.6",
     "@pcd/pcd-types": "0.11.4",
     "@pcd/pod": "0.1.7",
+    "@pcd/pod-ticket-pcd": "0.1.7",
     "@pcd/semaphore-group-pcd": "0.11.6",
     "@pcd/semaphore-identity-pcd": "0.11.6",
     "@pcd/pod-pcd": "0.1.7",

diff --git a/packages/lib/passport-interface/src/RequestTypes.ts b/packages/lib/passport-interface/src/RequestTypes.ts
@@ -2,6 +2,8 @@ import { EdDSAPublicKey } from "@pcd/eddsa-pcd";
 import { EdDSATicketPCD, EdDSATicketPCDTypeName } from "@pcd/eddsa-ticket-pcd";
 import { PCDAction } from "@pcd/pcd-collection";
 import { ArgsOf, PCDOf, PCDPackage, SerializedPCD } from "@pcd/pcd-types";
+
+import { IPODTicketData } from "@pcd/pod-ticket-pcd/src/schema";
 import { SerializedSemaphoreGroup } from "@pcd/semaphore-group-pcd";
 import { SemaphoreSignaturePCD } from "@pcd/semaphore-signature-pcd";
 import { Credential } from "./Credential";
@@ -1238,11 +1240,5 @@ export type OneClickEmailResponseValue = {
 };
 
 export type TicketPreviewResultValue = {
-  tickets: Array<{
-    name: string;
-    email: string;
-    ticketSecret: string;
-    eventName: string;
-    productName: string;
-  }>;
+  tickets: Array<IPODTicketData>;
 };
diff --git a/packages/lib/passport-interface/tsconfig.cjs.json b/packages/lib/passport-interface/tsconfig.cjs.json
@@ -34,6 +34,9 @@
     {
       "path": "../pod/tsconfig.cjs.json"
     },
+    {
+      "path": "../../pcd/pod-ticket-pcd/tsconfig.cjs.json"
+    },
     {
       "path": "../../pcd/semaphore-group-pcd/tsconfig.cjs.json"
     },

diff --git a/packages/lib/passport-interface/tsconfig.esm.json b/packages/lib/passport-interface/tsconfig.esm.json
@@ -34,6 +34,9 @@
     {
       "path": "../pod/tsconfig.esm.json"
     },
+    {
+      "path": "../../pcd/pod-ticket-pcd/tsconfig.esm.json"
+    },
     {
       "path": "../../pcd/semaphore-group-pcd/tsconfig.esm.json"
     },

diff --git a/packages/lib/passport-interface/tsconfig.json b/packages/lib/passport-interface/tsconfig.json
@@ -45,6 +45,9 @@
     {
       "path": "../pod"
     },
+    {
+      "path": "../../pcd/pod-ticket-pcd"
+    },
     {
       "path": "../../pcd/semaphore-group-pcd"
     },

diff --git a/packages/pcd/pod-ticket-pcd/src/index.ts b/packages/pcd/pod-ticket-pcd/src/index.ts
@@ -1,2 +1,3 @@
 export * from "./PODTicketPCD";
 export * from "./PODTicketPCDPackage";
+export * from "./schema";