Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate app state before performing potentially destructive actions: sync, save, download, upload #1348

Merged
merged 73 commits into from
Dec 19, 2023
Merged

validate app state before performing potentially destructive actions: sync, save, download, upload #1348

merged 73 commits into from
Dec 19, 2023

Conversation

ichub
Copy link
Contributor

@ichub ichub commented Dec 11, 2023

closes #1341

@ichub ichub force-pushed the ivan/state-validation branch from 4c4095e to 0aa824c Compare December 11, 2023 21:04
artwyman
artwyman requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@artwyman artwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely on the right track. I made a bunch of comments of things to consider or where I might approach things differently.

apps/passport-client/components/modals/InvalidUserModal.tsx Show resolved Hide resolved
apps/passport-client/pages/index.tsx Outdated Show resolved Hide resolved
apps/passport-client/src/dispatch.ts Show resolved Hide resolved
apps/passport-client/src/dispatch.ts Outdated Show resolved Hide resolved
apps/passport-client/src/dispatch.ts Outdated Show resolved Hide resolved
apps/passport-client/pages/index.tsx Show resolved Hide resolved
apps/passport-client/src/validateState.ts Outdated Show resolved Hide resolved
apps/passport-client/src/validateState.ts Show resolved Hide resolved
apps/passport-client/src/validateState.ts Outdated Show resolved Hide resolved
apps/passport-client/src/validateState.ts Outdated Show resolved Hide resolved
@ichub ichub mentioned this pull request Dec 15, 2023
Closed
@ichub ichub force-pushed the ivan/state-validation branch from a01ed57 to 3e30ce2 Compare December 15, 2023 04:50
@ichub ichub changed the title [wip] state validation state validation Dec 18, 2023
@ichub ichub marked this pull request as ready for review December 18, 2023 21:37
@ichub ichub requested a review from artwyman December 18, 2023 22:46
@artwyman artwyman mentioned this pull request Dec 19, 2023
Merged
@ichub ichub force-pushed the ivan/state-validation branch from 7b31818 to b7c881d Compare December 19, 2023 00:44
@ichub
early return on upload validation error; this doesn't cause upload lo…
f4999f1 
…op b/c there is an even earlier early return that exits the sync code in the case that the userInvalid flat is set
@ichub
Copy link
Contributor Author

ichub commented Dec 19, 2023

invalid zupass modal now looks like this:

Screenshot 2023-12-18 at 5 42 13 PM

@ichub ichub changed the title state validation validate app state before performing potentially destructive actions: sync, save, download, upload Dec 19, 2023
@ichub ichub added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit e88d2b2 Dec 19, 2023
1 check passed
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2023
@robknight
Allow rate-limit service to be disabled by an environment variable (#…
35e022b 
…1368)

In #1348 @ichub had to
disable rate-limiting by changing code in the rate-limiting service.
This PR introduces an environment variable for causing the rate-limiting
service to permit all actions, e.g. for local testing and development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artwyman artwyman artwyman approved these changes

@robknight robknight robknight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect, report, and isolate invalid PCD states
3 participants
@ichub @artwyman @robknight