Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPL3 license to relevant apps and root #1685

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Add GPL3 license to relevant apps and root #1685

merged 4 commits into from
Jul 26, 2024

Conversation

rrrliu
Copy link
Collaborator

@rrrliu rrrliu commented May 13, 2024

No description provided.

@rrrliu rrrliu requested a review from artwyman May 13, 2024 09:20
Copy link
Member

@artwyman artwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also review the package.json files to see if they include the right license specifier? I didn't review them all, but it looks like anon-message-client at least doesn't have a license in its package.json at all.

Something I wonder (but don't know for sure because IANAL) is whether we need to specify a license at the top-level at all, and which license it should be. We have a mix of MIT-licensed packages and GPL-licensed packages in this repo, and I'm not sure how the precedence is supposed to work for a top-level license. I might've gone with an MIT license as default, assuming it only covers things like our tsconfig and other things which aren't in a specific package with its own license.

@rrrliu rrrliu requested a review from artwyman July 22, 2024 06:26
@rrrliu
Copy link
Collaborator Author

rrrliu commented Jul 22, 2024

Can you also review the package.json files to see if they include the right license specifier? I didn't review them all, but it looks like anon-message-client at least doesn't have a license in its package.json at all.

Fixed, thanks for the heads up.

Something I wonder (but don't know for sure because IANAL) is whether we need to specify a license at the top-level at all, and which license it should be. We have a mix of MIT-licensed packages and GPL-licensed packages in this repo, and I'm not sure how the precedence is supposed to work for a top-level license. I might've gone with an MIT license as default, assuming it only covers things like our tsconfig and other things which aren't in a specific package with its own license.

After some minor research [0] [1] [2], it looks like setting GPL3 as the default top-level license is probably the safest option. Of course IANAL so quick confirmation with lawyers could make sense here.

[0] https://opensource.stackexchange.com/questions/13029/how-mixing-mit-licensed-code-with-gplv3-project-works
[1] https://www.thehyve.nl/articles/open-source-software-licenses-part-3
[2] https://qr.ae/p27bPN

@rrrliu rrrliu merged commit d29e815 into main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants