Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case insensitive issuance #1829

Merged
merged 3 commits into from
Jul 17, 2024
Merged

case insensitive issuance #1829

merged 3 commits into from
Jul 17, 2024

Conversation

ichub
Copy link
Contributor

@ichub ichub commented Jul 17, 2024 •
edited
Loading

@ichub ichub requested a review from robknight July 17, 2024 20:10
@ichub ichub marked this pull request as ready for review July 17, 2024 20:10
@robknight
Copy link
Member

robknight commented Jul 17, 2024 •
edited
Loading

This looks good to me. I wonder if we might be better off in the long run with an isEqualEmail(a, b) function, which automatically converts a and b to lowercase, and might be harder to forget, but that doesn't seem worth trying to do now.

@ichub ichub added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 489c799 Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robknight robknight robknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichub @robknight