UI Phase2 - Adding new screens #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: or orsatti <[email protected]> Co-authored-by: GuySerfaty <[email protected]>
Missing from this PR:
- [ ] Copy on manage email modal
- [ ] Loading tickets state - waiting for answer on linear
- [ ] Border on floating buttons - Need to ask Joseph
- [ ] Order tickets by dates- missing event duration and time.
- [ ] Remove title and subtitle from pod UI - left questions
- [ ] Fake name on ticket ("Johnny Cash") - exist only locally for test
purposes, for now commented out
- [ ] swipe indicator on home page - waiting for mockups
- [ ] login-interstitial state - Will add in phase3 PR
ichub
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
- there are a few minor things left over from my review, use discretion to follow up on those
- i've noted a few new problems in the earlier notion doc here - @rrrliu, please figure out how to prioritize/assign those
- i think the best way to proceed is to merge this now, then follow up with a bunch of testing. most of the code is basically fine.
| return useMemo(() => { | ||
| const eventsMap = new Map<string, TicketPack[]>(); | ||
| for (const ticket of tickets) { | ||
| if (ticket.claim.ticket.ticketName !== "GA") continue; |
There was a problem hiding this comment.
| }); | ||
| } | ||
| for (const ticket of tickets) { | ||
| if (ticket.claim.ticket.ticketName === "GA") continue; |
There was a problem hiding this comment.
Comment on lines
85
to
86
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [ticketsTrigger]); |
There was a problem hiding this comment.
please either address this or explain why it's necessary
| const dispatch = useDispatch(); | ||
| const scrollRef = useRef<HTMLDivElement>(null); | ||
| const pcdCardScrollRef = useRef<HTMLDivElement>(null); | ||
| const ticketsRef = useRef<Map<string, HTMLDivElement[]>>(new Map()); |
at the below the tickets list
rrrliu
reviewed
Oct 9, 2024
rrrliu
pushed a commit
that referenced
this pull request
Oct 14, 2024
Co-authored-by: or orsatti <[email protected]> Co-authored-by: GuySerfaty <[email protected]> Co-authored-by: Ivan Chub <[email protected]> Co-authored-by: Ivan Chub <[email protected]> Co-authored-by: Or Antonio Orsatti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.