fast one click #1907
Merged
fast one click #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichub
force-pushed
the
ivan/fast-one-click
branch
from
c84167e
to
d67f76d
Compare
ichub
force-pushed
the
ivan/fast-one-click
branch
3 times, most recently
from
0f9f929
to
996e3a3
Compare
ichub
force-pushed
the
ivan/fast-one-click
branch
from
996e3a3
to
0b3b1aa
Compare
rrrliu
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Nothing that we'll need to communicate this screen (and the associated "continue to zupass") to 10play team -- probably on our meeting monday
Comment on lines
+369
to
+374
| if (!pipeline) { | ||
| throw new PCDHTTPError( | ||
| 400, | ||
| "handleGetTicketPreview: pipeline not found " + requestedPipelineId | ||
| ); | ||
| } |
There was a problem hiding this comment.
will this break any existing 1-click links, i.e. do we handle the 400 on the client?
There was a problem hiding this comment.
i've now split the new one-click page out from the old one so that none of the new code interferes with the old flows
| setError(previewRes.error); | ||
| } | ||
| } catch (err) { | ||
| await dispatch({ |
There was a problem hiding this comment.
related to previous comment about handling the 400 -- should this just actually call handleOneClickLogin() e.g. for the Esmeralda and Prague links that were sent out?
rrrliu
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/0xparc-pcd/issue/0XP-1150/ttt-time-to-ticket-performance-improvements