Vertical scroll for POD & GPC PCDs #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichub
approved these changes
Sep 30, 2024
artwyman
force-pushed
the
artwman/vscroll
branch
from
cb439f0
to
59baed0
Compare
artwyman
force-pushed
the
artwman/vscroll
branch
from
59baed0
to
34c9c42
Compare
rrrliu
pushed a commit
that referenced
this pull request
Oct 8, 2024
Add vertical scrolling to POD-PCD and GPC-PCD Closes https://linear.app/0xparc-pcd/issue/0XP-1087/vertical-scrolling-for-podgpc-display-text Note this PR is dependent on #1881. This happened because my local test server is broken without UnknownPCD. Which I could ignore, but I see this is a reasonable test case to see how to get stacked PRs to work. I've marked this as merging into the parent PR's branch, and I'll figure out later how to update it when the parent PR merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vertical scrolling to POD-PCD and GPC-PCD
Closes https://linear.app/0xparc-pcd/issue/0XP-1087/vertical-scrolling-for-podgpc-display-text
Note this PR is dependent on #1881. This happened because my local test server is broken without UnknownPCD. Which I could ignore, but I see this is a reasonable test case to see how to get stacked PRs to work. I've marked this as merging into the parent PR's branch, and I'll figure out later how to update it when the parent PR merges.