Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify pipeline retry logic #2118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

simplify pipeline retry logic #2118

wants to merge 2 commits into from

Conversation

ichub
Copy link
Contributor

@ichub ichub commented Nov 6, 2024 •
edited
Loading

  • now, when you edit a pipeline (e.g. by changing its name or by unpausing), instead of loading immediately, the system waits until all the existing pipelines either finish loading (successfully or unsuccessfully)
    • this simplifies some of the pipeline scheduling logic, which would prevent issues like this one
  • pipeline loads are now capped at 10 minutes - after that the load rejects

@ichub ichub force-pushed the ivan/abort branch 16 times, most recently from 8c82f25 to f40d2d2 Compare November 6, 2024 07:24
@ichub ichub requested a review from rrrliu November 6, 2024 07:25
@ichub ichub marked this pull request as ready for review November 6, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrrliu rrrliu rrrliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichub @rrrliu