Allow claiming of tickets without subscription #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrliu
reviewed
Dec 13, 2024
| <NEW_UI__ExtraInfo>•</NEW_UI__ExtraInfo> | ||
| )} | ||
| {ticketData?.attendeeEmail && | ||
| ticketData?.attendeeEmail !== ticketData?.attendeeName && ( |
There was a problem hiding this comment.
why are we hiding if email == name?
Comment on lines
141
to
149
| } else { | ||
| setError("No ticket found"); | ||
| } | ||
| } else { | ||
| setError("No ticket found"); | ||
| } | ||
| } else { | ||
| setError("No ticket found"); | ||
| } |
There was a problem hiding this comment.
wrap these in one if/else statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/0xparc-pcd/issue/0XP-1697/improved-subscription-screen
This adds a new "Claim" screen, which is designed to work specifically with Podbox feeds.
It polls the feed, extracting the POD Ticket PCD from the feed actions, and then presents a preview of the ticket to the user. If the user clicks "Claim", the ticket is added to their PCD collection.
This allows users to collect tickets without needing to subscribe to feeds or to grant ongoing permissions for feeds to access folders, including taking destructive actions like deleting PCDs. It also avoids the overhead of recurring feed polling, both on the client and on Podbox.
To test, get a feed link from Podbox in the same environment you're testing in and then go to https://zupass-url/#/claim?type=ticket&url=
This should show a ticket preview, assuming that you have a ticket available for your email address on the feed in question.