Add support for React 19 as a peer dependency #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 19 now has a stable release and so we can expect to see third-party apps using it.
Our packages specify that React ^18.2.0 is a supported peer dependency, but this excludes React 19. In initial testing it seems that our packages work with React 19, and so it should be listed as a valid peer dependency.
The effect on third-party developers is that they will be able to use our packages with React 19 without receiving warnings or errors from their package manager, and without having to override those warnings or errors (e.g. by using
--forceor--legacy-peer-depswithnpm).I've added a changeset for this, which can be used to version-bump the affected packages when this PR is accepted.