Use float seconds for timestamps and stopwatch #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion settings are configured
|
@karpilin Sorry for that and thanks for finding the issue. |
|
@karpilin seems like CS checks fail, would you mind running the fixer? |
|
@prolic I have fixed what was flagged by cs-fixer |
|
Submitting to https://coveralls.io/api/v1/jobs Can you check what's going on? your changes are fine, I'm going to merge. thanks for your contribution. |
|
@prolic thank you for finding time to maintain this library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use float seconds for timestamps and stopwatch as per how the connection settings are configured.
This is the code by @grymmare from #170 that was previously merged in and then reverted (mistakenly?) in #176