Close #44: Set correct failed phase for dispatch exception

- Allow listeners to unset exception
prooph · Jan 12, 2015 · a97c4ab · a97c4ab
1 parent a62989d
commit a97c4ab
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/Prooph/ServiceBus/CommandBus.php b/src/Prooph/ServiceBus/CommandBus.php
@@ -150,10 +150,19 @@ public function dispatch($command)
             $this->trigger($commandDispatch);
 
         } catch (\Exception $ex) {
+            $failedPhase = $commandDispatch->getName();
+
             $commandDispatch->setException($ex);
             $this->triggerError($commandDispatch);
             $this->triggerFinalize($commandDispatch);
-            throw CommandDispatchException::failed($commandDispatch, $ex);
+
+            //Check if a listener has removed the exception to indicate that it was able to handle it
+            if ($ex = $commandDispatch->getException()) {
+                $commandDispatch->setName($failedPhase);
+                throw CommandDispatchException::failed($commandDispatch, $ex);
+            }
+
+            return;
         }
 
         $this->triggerFinalize($commandDispatch);

diff --git a/src/Prooph/ServiceBus/EventBus.php b/src/Prooph/ServiceBus/EventBus.php
@@ -139,10 +139,20 @@ public function dispatch($event)
             }
 
         } catch (\Exception $ex) {
+            $failedPhase = $eventDispatch->getName();
             $eventDispatch->setException($ex);
+
             $this->triggerError($eventDispatch);
             $this->triggerFinalize($eventDispatch);
-            throw EventDispatchException::failed($eventDispatch, $ex);
+
+            //Check if a listener has removed the exception to indicate that it was able to handle it
+            if ($ex = $eventDispatch->getException()) {
+                $eventDispatch->setName($failedPhase);
+                throw EventDispatchException::failed($eventDispatch, $ex);
+            }
+
+            return;
+
         }
 
         $this->triggerFinalize($eventDispatch);