#WIP Improvements to offspring_controller #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebjimenez
changed the title
|
This PR is under revision due to a bug in one of the specs. Working on it! |
sebjimenez
force-pushed
the
offs_controller_fix
branch
from
5f0bd43
to
3298542
Compare
|
Ready to review. Waiting for feedback. @sergio-ocon @alexvkcr @katafira @agarciavera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to remove the static alert/success messages when executing actions from the offspring controller. Using locales/es.yml and SCOPE instead of static string messages, to be capable of displaying the result of the controller's action in several languages.
Also to optimize the 'create' method of the offspring controller given that rubocop found an offense in that method.
IMPORTANT: this PR depends of the PR #14 from @alexvkcr - branch: admin_stop