Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Accessing AsyncComputed status property should trigger computed function #88

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/async-computed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class AsyncComputed<T> {
* already.
*/
get status() {
this.run();
// Unconditionally read the status signal to ensure that any signals that
// read it are tracked as dependents.
const currentState = this.#status.get();
Expand Down
4 changes: 2 additions & 2 deletions tests/async-computed.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ describe("AsyncComputed", () => {
await 0;
return 1;
});
assert.equal(task.status, "initial");

// Getting the value starts the task
// Getting the value (or status and other properties) starts the task
assert.equal(task.status, "pending");
assert.strictEqual(task.value, undefined);
assert.strictEqual(task.error, undefined);
assert.equal(task.status, "pending");
Expand Down
Loading