Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team bitkey!
Danny here from WalletScrutiny. I recently did a build for version 2024.63.0 (4). And it came out as reproducible
WalletScrutiny has a remote debian based build server that cannot connect to my phone. :)
Doing the build on a local machine with a connected phone crashes for me.
(You can skip to the end part of the asciicast)
https://asciinema.org/a/hZFLhGnDU8i4ijh4A0oxYg66i
I just thought I'd share a little modification I made to your verification script.
Step 1: Download the Split APKs from phone on a local machine by running
steps/download-apk-from-phone
Step 2: Generate the device-spec.json file with
bundletool get-device-spec --output=device-spec.json
Step 3: Upload the split apks and device-spec.json on local machine to a folder on build server
Step 4: Proceed with the instructions here..
verify-android-apk
andconvert-aab-to-apks
which I included in this PR.Step 5 Proceed with other prep steps. Then run
verify-android-apk
with