Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/allowPreDownloadedSplitsAPKs #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xrviv
Copy link

@xrviv xrviv commented Jul 25, 2024

Hello team bitkey!

Danny here from WalletScrutiny. I recently did a build for version 2024.63.0 (4). And it came out as reproducible

WalletScrutiny has a remote debian based build server that cannot connect to my phone. :)
Doing the build on a local machine with a connected phone crashes for me.

(You can skip to the end part of the asciicast)

https://asciinema.org/a/hZFLhGnDU8i4ijh4A0oxYg66i

I just thought I'd share a little modification I made to your verification script.

Step 1: Download the Split APKs from phone on a local machine by running steps/download-apk-from-phone
Step 2: Generate the device-spec.json file with bundletool get-device-spec --output=device-spec.json
Step 3: Upload the split apks and device-spec.json on local machine to a folder on build server
Step 4: Proceed with the instructions here..

  • After cloning, change the following scripts: verify-android-apk and convert-aab-to-apks which I included in this PR.

Step 5 Proceed with other prep steps. Then run verify-android-apk with

$ ./verify-android-apk -d /path/to/apk/directory -s /path/to/device-spec.json /path/to/bitkey/repo/on/build/machine /path/to/build/directory/on/build/machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant