Skip to content

Update to protobuf 30.1 and drop bazel workspace configuration #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

dibenede
Copy link
Contributor

The proto descriptor API has changed to return absl::string_views instead of std::string, which is preventing users from building at HEAD.

This change bumps our dependency to protobuf 30.1 and migrates our code generator as needed so we can build with absl::string_view values.

At the same time, Bazel is getting ready to drop workspace support (disabled by default as of EOY2024/Bazel 8). Protobuf still seems to support both, but opportunistically taking this opportunity to just use Bazel models. We can temporarily add back workspace support if users actually need it.

The proto descriptor API has changed to return absl::string_views
instead of std::string, which is preventing users from building at
HEAD.

This change bumps our dependency to protobuf 30.1 and migrates our
code generator as needed so we can build with absl::string_view values.

At the same time, Bazel is getting ready to drop workspace support
(disabled by default as of EOY2024/Bazel 8). Protobuf still seems to
support both, but opportunistically taking this opportunity to just
use Bazel models. We can temporarily add back workspace support if
users actually need it.
@dibenede dibenede requested a review from lukesandberg March 17, 2025 17:51
@lukesandberg lukesandberg merged commit 5f41cae into protocolbuffers:main Mar 17, 2025
4 checks passed
@dibenede dibenede deleted the update-protobuf branch March 17, 2025 17:59
@garetman
Copy link

garetman commented Jun 6, 2025

$ repo sync -c -j8

@garetman
Copy link

garetman commented Jun 6, 2025

$ gpg --import keyfile.asc

@garetman
Copy link

garetman commented Jun 6, 2025

$ git tag -v TAG_YARILO

@garetman
Copy link

garetman commented Jun 6, 2025

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

mQGiBEnnWD4RBACt9/h4v9xnnGDou13y3dvOx6/t43LPPIxeJ8eX9WB+8LLuROSV
lFhpHawsVAcFlmi7f7jdSRF+OvtZL9ShPKdLfwBJMNkU66/TZmPewS4m782ndtw7
8tR1cXb197Ob8kOfQB3A9yk2XZ4ei4ZC3i6wVdqHLRxABdncwu5hOF9KXwCgkxMD
u4PVgChaAJzTYJ1EG+UYBIUEAJmfearb0qRAN7dEoff0FeXsEaUA6U90sEoVks0Z
wNj96SA8BL+a1OoEUUfpMhiHyLuQSftxisJxTh+2QclzDviDyaTrkANjdYY7p2cq
/HMdOY7LJlHaqtXmZxXjjtw5Uc2QG8UY8aziU3IE9nTjSwCXeJnuyvoizl9/I1S5
jU5SA/9WwIps4SC84ielIXiGWEqq6i6/sk4I9q1YemZF2XVVKnmI1F4iCMtNKsR4
MGSa1gA8s4iQbsKNWPgp7M3a51JCVCu6l/8zTpA+uUGapw4tWCp4o0dpIvDPBEa9
b/aF/ygcR8mh5hgUfpF9IpXdknOsbKCvM9lSSfRciETykZc4wrRCVGhlIEFuZHJv
aWQgT3BlbiBTb3VyY2UgUHJvamVjdCA8aW5pdGlhbC1jb250cmlidXRpb25AYW5k
cm9pZC5jb20+iGAEExECACAFAknnWD4CGwMGCwkIBwMCBBUCCAMEFgIDAQIeAQIX
gAAKCRDorT+BmrEOeNr+AJ42Xy6tEW7r3KzrJxnRX8mij9z8tgCdFfQYiHpYngkI
2t09Ed+9Bm4gmEO5Ag0ESedYRBAIAKVW1JcMBWvV/0Bo9WiByJ9WJ5swMN36/vAl
QN4mWRhfzDOk/Rosdb0csAO/l8Kz0gKQPOfObtyYjvI8JMC3rmi+LIvSUT9806Up
hisyEmmHv6U8gUb/xHLIanXGxwhYzjgeuAXVCsv+EvoPIHbY4L/KvP5x+oCJIDbk
C2b1TvVk9PryzmE4BPIQL/NtgR1oLWm/uWR9zRUFtBnE411aMAN3qnAHBBMZzKMX
LWBGWE0znfRrnczI5p49i2YZJAjyX1P2WzmScK49CV82dzLo71MnrF6fj+Udtb5+
OgTg7Cow+8PRaTkJEW5Y2JIZpnRUq0CYxAmHYX79EMKHDSThf/8AAwUIAJPWsB/M
pK+KMs/s3r6nJrnYLTfdZhtmQXimpoDMJg1zxmL8UfNUKiQZ6esoAWtDgpqt7Y7s
KZ8laHRARonte394hidZzM5nb6hQvpPjt2OlPRsyqVxw4c/KsjADtAuKW9/d8phb
N8bTyOJo856qg4oOEzKG9eeF7oaZTYBy33BTL0408sEBxiMior6b8LrZrAhkqDjA
vUXRwm/fFKgpsOysxC6xi553CxBUCH2omNV6Ka1LNMwzSp9ILz8jEGqmUtkBszwo
G1S8fXgE0Lq3cdDM/GJ4QXP/p6LiwNF99faDMTV3+2SAOGvytOX6KjKVzKOSsfJQ
hN0DlsIw8hqJc0WISQQYEQIACQUCSedYRAIbDAAKCRDorT+BmrEOeCUOAJ9qmR0l
EXzeoxcdoafxqf6gZlJZlACgkWF7wi2YLW3Oa+jv2QSTlrx4KLM=
=Wi5D
-----END PGP PUBLIC KEY BLOCK-----

@garetman
Copy link

garetman commented Jun 6, 2025

The proto descriptor API has changed to return absl::string_views instead of std::string, which is preventing users from building at HEAD.

This change bumps our dependency to protobuf 30.1 and migrates our code generator as needed so we can build with absl::string_view values.

At the same time, Bazel is getting ready to drop workspace support (disabled by default as of EOY2024/Bazel 8). Protobuf still seems to support both, but opportunistically taking this opportunity to just use Bazel models. We can temporarily add back workspace support if users actually need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants