Skip to content

Commit

Permalink
C#: Remove TODO, replacing it with an explanation.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 626125905
  • Loading branch information
protobuf-github-bot authored and copybara-github committed Apr 18, 2024
1 parent ffd5c1b commit 2be4364
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion csharp/src/Google.Protobuf/Reflection/FieldDescriptor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,12 @@ internal void CrossLink()
IDescriptor typeDescriptor =
File.DescriptorPool.LookupSymbol(Proto.TypeName, this);

// TODO: See how much of this is actually required.
// In most cases, the type will be specified in the descriptor proto. This may be
// guaranteed in descriptor.proto in the future (with respect to spring 2024), but
// we may still see older descriptors created by old versions of protoc, and there
// may be some code creating descriptor protos directly. This code effectively
// maintains backward compatibility, but we don't expect it to be a path taken
// often at all.
if (!Proto.HasType)
{
// Choose field type based on symbol.
Expand Down

0 comments on commit 2be4364

Please sign in to comment.